Remove qmake project files. #603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Wenzel <[email protected]>
|
@hannesa2 Can i remove this? Is qmake build necessary for MacOS? C:\workspace\github\covesa\dlt-viewer\scripts\darwin\build_cmake.sh (2 hits) |
Signed-off-by: Alexander Wenzel <[email protected]>
Update documentation. Signed-off-by: Alexander Wenzel <[email protected]>
|
@hannesa2 Please review if this PR is ok for MacOs |
hannesa2
approved these changes
Dec 11, 2024
| build/ | ||
| .project | ||
| Makefile | ||
| buildlib/ | ||
| release/ | ||
| .cproject | ||
| *.pro.user* |
There was a problem hiding this comment.
Not sure if this helps anyone or improve something.
But it's not wrong.
| @@ -19,7 +19,7 @@ Alexander Wenzel <[email protected]> | |||
| * sudo apt install libqt5serialport5-dev | |||
| * mkdir build | |||
| * cd build | |||
| * qmake ../BuildDltViewer.pro | |||
| * cmake .. | |||
There was a problem hiding this comment.
This complete INSTALL.md is always outdated like a newspaper, I would simply point to the CI build script and delete complete file
| @@ -14,13 +14,13 @@ cd "${BUILD_DIR}" | |||
| if [[ $(uname -m) == 'arm64' ]]; then | |||
| Qt5_DIR="/opt/homebrew/opt/qt@5" | |||
| echo "Build with cmake $(uname -m) $Qt5_DIR" | |||
| qmake ../BuildDltViewer.pro | |||
| # qmake ../BuildDltViewer.pro | |||
There was a problem hiding this comment.
You could delete lines complete, including the echo before
| # cmake .. | ||
| else | ||
| Qt5_DIR="/usr/local/opt/qt" | ||
| echo "Build with qmake $(uname -m) $Qt5_DIR" | ||
| qmake ../BuildDltViewer.pro | ||
| make | ||
| # qmake ../BuildDltViewer.pro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.